feat!: use TYPESENSE_URLS for cluster support#3
Merged
samuelallan72 merged 1 commit intomainfrom Aug 28, 2025
Merged
Conversation
7 tasks
bradenmacdonald
approved these changes
Aug 28, 2025
This plugin doesn't provide clustered Typesense support (yet), but switch to using TYPESENSE_URLS for cluster support in the Open edX components. Private-ref: https://tasks.opencraft.com/browse/BB-9975
684dc56 to
6886c7f
Compare
Member
Author
|
@bradenmacdonald thanks! I dropped the note about "The first url should be considered the "primary" or "closest" url.", as I'm not sure how we might want to handle that possibility. This makes it simpler for now. (Please let me know if you'd prefer the note was kept) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This plugin doesn't provide clustered Typesense support (yet), but switch to using TYPESENSE_URLS for cluster support in the Open edX components.
Supporting information
Private-ref: https://tasks.opencraft.com/browse/BB-9975
Test instructions
Deadline
None